search

kserve / models-web-app

KServe models web UI
Apache License 2.0
33 stars 40 forks source link

Canary Rollout From KF-Serving Web App UI #2

Open sriharan16 opened 3 years ago

sriharan16 commented 3 years ago

/kind feature

Describe the solution you'd like I was trying the KF-Serving model web app and tried to deploy a canary rollout that was working using Kubectl commands but I don’t see any option for it in the model web app UI.

Here the web app supports the YAML structure and uses the v1beta1 API. So we deployed a default model version and it got successfully deployed and changes reflected in web app. Now we wanted to deploy a canary model which needs the YAML to be modified with canaryTrafficPercent value which looks not possible from UI as we don’t see any edit option in UI. Also when we rollout the canary from UI as we do via kubectl I'm getting an error saying model with name 'my-model' already exists. I would like to have an edit feature or canary rollout feature from the UI which makes it easy for everyone to work with.

The document I followed was, https://github.com/kubeflow/kfserving/tree/master/docs/samples/v1beta1/rollout

Anything else you would like to add: I see two ways to achieve this part.

@kimwnasptd I hope this should be helpful to track and develop the same.

One more request is when developing a new feature please update the doc so we can utilize the same, because for python SDK docs we have v1alpha2 examples that are not supported post-kf-serving 0.6.0 version.

sriharan16 commented 3 years ago

Hi, Any update on this as this is stale for about 2 weeks.

markwinter commented 2 years ago

@sriharan16

I will work on this soon!

I think there will probably be two separate features?

  1. Edit a model server
    • This is to edit things like autoscaling settings, resource settings etc.
  2. Canary rollout
    • This will allow you to just set the new storageUri and the traffic percentage

Or maybe it should all be one Edit Model Server form, I'm not sure yet

sriharan16 commented 2 years ago

Hi, That's great news. It can be either way as you said.

Just to add, the functionality was expected to perform the rollout present in this doc via the model server UI similar to how we do it in the CLI using .yaml files and kubectl. If this is possible it will be the best part of the Web APP UI.

markwinter commented 2 years ago

FYI I am working on this now.

I will add an Edit button that loads the existing YAML which you can edit to change the storageUri and add the canaryTrafficPercent

This should be a quick solution that satisfies most use-cases

Later on I can make a nicer UI

javen218 commented 2 years ago

Does models-web-app v0.8.0 already support canary rollout? If not, is there any plan? @markwinter @kimwnasptd I want to know what release could has this basic and really really iportant feature!