search

kserve / models-web-app

KServe models web UI
Apache License 2.0
33 stars 40 forks source link

mwa(front): Use common lib-logs-viewer component #52

Closed orfeas-k closed 1 year ago

orfeas-k commented 1 year ago

This is a follow-up PR to this and replaces MWA's logs viewer component with the one from Kubeflow's common library to avoid having and maintaining the same component twice.

elenzio9 commented 1 year ago

I tested this PR and everything works as expected. Thanks, @orfeas-k! cc @kimwnasptd /lgtm

kserve-oss-bot commented 1 year ago

@elenzio9: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kserve/models-web-app/pull/52#issuecomment-1370944504): >I tested this PR and everything works as expected. Thanks, @orfeas-k! >cc @kimwnasptd >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
elenzio9 commented 1 year ago

@orfeas-k Could you rebase the branch on top of the latest master to fix the conflicts?

orfeas-k commented 1 year ago

Rebased and pushed @elenzio9

kimwnasptd commented 1 year ago

/lgtm /approve

kserve-oss-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, orfeas-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/models-web-app/blob/master/OWNERS)~~ [kimwnasptd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment