search

kserve / models-web-app

KServe models web UI
Apache License 2.0
33 stars 40 forks source link

frontend: Rename models to endpoints #57

Closed elenzio9 closed 1 year ago

elenzio9 commented 1 year ago

This PR renames models to endpoints.

image image image

Related issue: https://github.com/kserve/kserve/issues/2534

kimwnasptd commented 1 year ago

@orfeas-k @elenzio9 for Copy endpoint let's do Copy endpoint's url

@elenzio9 let's also update this small sentence in the README:

This web app is responsible for allowing the user to manipulate the Model Servers...

to

This web app is responsible for allowing the user to manipulate the Model Servers (Endpoints)...
elenzio9 commented 1 year ago

Thanks @kimwnasptd @orfeas-k for your suggestions! I'll make the changes and push the branch again.

@kimwnasptd What about the title of the README file? Models web app to Endpoints web app

kimwnasptd commented 1 year ago

@kimwnasptd What about the title of the README file? Models web app to Endpoints web app Let's leave this part as is for now

kimwnasptd commented 1 year ago

Thanks!

/lgtm /approve

kserve-oss-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/models-web-app/blob/master/OWNERS)~~ [kimwnasptd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment