search

kserve / models-web-app

KServe models web UI
Apache License 2.0
33 stars 40 forks source link

Fix displaying MLFlow predictors #74

Closed rvalkenaers closed 2 weeks ago

rvalkenaers commented 1 year ago

Currently MLFlow predictors cannot be handled by the web app but they are supported by kserve: https://kserve.github.io/website/0.10/modelserving/v1beta1/mlflow/v2/

This PR adds MLFlow to the list of predictor types.

rvalkenaers commented 1 year ago

/assign @yuzisun

kimwnasptd commented 1 year ago

Thanks @rvalkenaers!

/lgtm /approve

kserve-oss-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, rvalkenaers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/models-web-app/blob/master/OWNERS)~~ [kimwnasptd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rvalkenaers commented 1 year ago

@kimwnasptd

The "Fronted Test / Code format and lint" check is failing but it does not seem to be related to my change:

prettier requires at least version 14 of Node, please upgrade

Is this something you could look into?

AlessandroColantonio commented 8 months ago

Hello, I am new to KServe and this PR fixes the issue I am currently having with MLflow. Is there any plan to close it in the near future? Thank you!

kimwnasptd commented 5 months ago

@rvalkenaers could you rebase your PR, now that https://github.com/kserve/models-web-app/pull/77 is merged?

hansinikarunarathne commented 2 weeks ago

@juliusvonkohout you can close this PR. Because we merged the PR #96