search

kserve / models-web-app

KServe models web UI
Apache License 2.0
33 stars 40 forks source link

Allow custom ServingRuntimes #92

Closed hansinikarunarathne closed 1 month ago

hansinikarunarathne commented 1 month ago

fix issue with #47 PR

hansinikarunarathne commented 1 month ago

@juliusvonkohout can you please review this? Then I can fix the other two PRs which give the same issue.

juliusvonkohout commented 1 month ago

I see

 make: *** No rule to make target 'prettier-check'.  Stop.
Error: Process completed with exit code 2.
hansinikarunarathne commented 1 month ago

I see

 make: *** No rule to make target 'prettier-check'.  Stop.
Error: Process completed with exit code 2.

can you run it again @juliusvonkohout

juliusvonkohout commented 1 month ago

@hansinikarunarathne can you test this image once with our kserve workflow and check whether it works in the UI? https://github.com/kubeflow/manifests/blob/master/.github/workflows/kserve_m2m_test.yaml please upload a screenshot

juliusvonkohout commented 1 month ago

/ok-to-test

hansinikarunarathne commented 1 month ago

@juliusvonkohout can you please approve to run the test

hansinikarunarathne commented 1 month ago

@hansinikarunarathne can you test this image once with our kserve workflow and check whether it works in the UI? https://github.com/kubeflow/manifests/blob/master/.github/workflows/kserve_m2m_test.yaml please upload a screenshot

can you explain this bit more ?

hansinikarunarathne commented 1 month ago

If there is no any concerns regarding this PR, please approve this

juliusvonkohout commented 1 month ago

/lgtm /approve

juliusvonkohout commented 1 month ago

@hansinikarunarathne did you not test this locally as discussed? otherwise i have to revert it.

juliusvonkohout commented 1 month ago

Please create a PR to revert the change (keep the test fixes) if it does not pass the tests https://github.com/kubeflow/manifests/blob/master/.github/workflows/kserve_m2m_test.yaml and https://github.com/kubeflow/manifests/blob/master/.github/workflows/kserve_test.yaml

It should be in the workflows above and here is the explicit file kserve_test.yaml

They reported issues here with the PR https://github.com/kserve/models-web-app/pull/47#issuecomment-1331774027 and you need to make sure that there is no regression.