kserve / open-inference-protocol

Repository for open inference protocol specification
Apache License 2.0
42 stars 10 forks source link

Optional model version #14

Open zevisert opened 1 year ago

zevisert commented 1 year ago

The descriptions for "Model Ready" and "Model Metadata" in both the REST and gRPC specifications claim that the model version is optional. Is this true? If so, the specification should report it's optionality in more than a comment/description (optional in proto3 and required: false in openAPI). If the version is optional in the REST protocol, should there instead be another versionless route instead of eg, '/v2/models/${MODEL_NAME}/versions/${MODEL_VERSION}/ready'?

https://github.com/kserve/open-inference-protocol/blob/eeb043e2c95c1dd35f8b9185f5dadf44c7f10c9f/specification/protocol/open_inference_grpc.proto#L68-L70

https://github.com/kserve/open-inference-protocol/blob/eeb043e2c95c1dd35f8b9185f5dadf44c7f10c9f/specification/protocol/open_inference_grpc.proto#L98-L100

https://github.com/kserve/open-inference-protocol/blob/eeb043e2c95c1dd35f8b9185f5dadf44c7f10c9f/specification/protocol/open_inference_rest.yaml#L61

https://github.com/kserve/open-inference-protocol/blob/eeb043e2c95c1dd35f8b9185f5dadf44c7f10c9f/specification/protocol/open_inference_rest.yaml#L104