kserve / website

User documentation for KServe.
https://kserve.github.io/website/
Apache License 2.0
103 stars 109 forks source link

Add documentation for modelcars #337

Closed rhuss closed 3 months ago

rhuss commented 5 months ago

This PR adds user documentation for modelcars in the "User Guide" -> "Model Storage" section. Note, that this feature will be only available in the next version of KServe (0.12), so is currently only available on the main (aka master) branch.

netlify[bot] commented 5 months ago

Deploy Preview for elastic-nobel-0aef7a ready!

Name Link
Latest commit af335efa0462e343c72ffe5073d7c9056a82b132
Latest deploy log https://app.netlify.com/sites/elastic-nobel-0aef7a/deploys/65f1a42f864ccd0008274c8f
Deploy Preview https://deploy-preview-337--elastic-nobel-0aef7a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rhuss commented 5 months ago

The preview page does not work. I get an endless redirect loop when accessing https://deploy-preview-337--elastic-nobel-0aef7a.netlify.app/

yuzisun commented 5 months ago

The preview page does not work. I get an endless redirect loop when accessing https://deploy-preview-337--elastic-nobel-0aef7a.netlify.app/

Ye it stopped working recently we are looking into it.

yuzisun commented 5 months ago

The preview page does not work. I get an endless redirect loop when accessing https://deploy-preview-337--elastic-nobel-0aef7a.netlify.app/

Ye it stopped working recently we are looking into it. cc @andyi2it

rhuss commented 3 months ago

After 0.12 is now released and the modelcar functionality is available, could we get this documentation update into the website? The preview still doesn't work for me, but I would fix any formatting glitches in a followup PR (if it doesn't look as expected)

yuzisun commented 3 months ago

After 0.12 is now released and the modelcar functionality is available, could we get this documentation update into the website? The preview still doesn't work for me, but I would fix any formatting glitches in a followup PR (if it doesn't look as expected)

@rhuss The preview is fixed can you rebase the PR ?

rhuss commented 3 months ago

@yuzisun I checked the preview, and it looks good to me. From my side, the PR would be ready for prime time.

yuzisun commented 3 months ago

Thanks @rhuss !!

/lgtm /approve

oss-prow-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/website/blob/main/OWNERS)~~ [yuzisun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment