Google Actions changed from home control to Smart Home

kservices / gBridge

gBridge.io allows you to control (almost) anything with Google Assistant, by translating voice commands to MQTT messages.

https://about.gbridge.io

MIT License

173 stars 46 forks source link

Google Actions changed from home control to Smart Home #56

Open gwiersma opened 3 years ago

gwiersma commented 3 years ago

Instance Type (hosted/ docker/ other): Docker User ID (if using hosted service): Steps to reproduce issue:

Step 1: Setup Google action (Smart Home)
Step 2 Setup gBridge on Docker
Step 3: Try to link gBridge to Google Home

Expected behaviour: Account linking works as described in the documentation Actual behaviour: I have gBridge running on docker behind a Reverse Proxy. I am able to login but when i try to add the gbridge app to Google home, i receive the following error:

The request by Google Home was Malformed. Please try again in a few minutes. If this problem persists, please contact the team of Kappelt gBridge. Unkown Response Type Requesed!

When setting up the Google action, i saw that home control is not one of the options anymore. Instead it has become Smart Home. When setting up the account linking, i have to sepcify the Token URL (oauth endpoint for token exchange). I currently use the /bridge/gapi/auth url as value. Does any one have a idea?

lowlander07 commented 3 years ago

Ran into the same problem. For 'Smart Home' Google does not support the OAuth implicit code flow anymore.

jaburges commented 3 years ago

so is this DOA then now?

werty1st commented 3 years ago

i tried to implement something of this: https://laravel.com/docs/6.x/passport#code-grant-pkce but it looks like the gBridge is developed in laravel 5.5 and I don't know (if possible) how to upgrade it to at least laravel 6. 😞

peterkappelt commented 3 years ago

Hey guys, sorry for your inconvenience. I had to cancel development of the non-enterprise gBridge platform since it was not profitable. The code here hasn't been touched in a while and is probably outdated.

Migrating the authentication from the implicit code to authorization code flow or alike shouldn't be too hard.

Find the authentication part in gBridge
Redirect to the authorization URL of Google, with grant_type being set to authorization_code
Create a new endpoint in laravel/ gBridge for the callback of Google authorization
In this endpoint: check for errors, parse the returned auth code, call the "token" api endpoint of Google using this auth code, continue using the returned token (rather than the token directly returned by implicit flow)

Sorry that I can't provide more support

lowlander07 commented 3 years ago

Hi all, I'm trying to implement something as well. But Docker, PHP, etc. are all new for me. So some learning to do. But I make some progress. Just finished point 2 of Peter's list. Thanks for that Peter.

nayneyT commented 3 years ago

Hi everybody.

If you use use NodeRed as part of your home assistant setup then I suggest you take a look at https://github.com/mikejac/node-red-contrib-google-smarthome and https://flows.nodered.org/node/node-red-contrib-google-smarthome

It's an absolute shame that this project died.

Suryaobulareddy2932 commented 1 year ago

@lowlander07

Do you have any luck on this as @peterkappelt mentioned. If yes, please help me out

My mail id is suryaobulareddy@gmail.com

lowlander07 commented 1 year ago

@lowlander07

Do you have any luck on this as @peterkappelt mentioned. If yes, please help me out

My mail id is suryaobulareddy@gmail.com

Hi, yes I got it implemented and working. It's probably not the best code, but it works for me.

MrMarcel66 commented 1 year ago

@lowlander07 Can you share your solution with us please! I'm using gBridge for a while and i was very happy with this project. Too bad the project is dead i found it the best solution.

regards Marcel.

lowlander07 commented 1 year ago

Hi Marcel, Yes, the modified code is in here: https://github.com/lowlander07/gBridge Hope you can use it as well.

Regards, Bert

Op di 31 jan. 2023 om 23:42 schreef MrMarcel66 @.***>:

@lowlander07 https://github.com/lowlander07 Can you share your solution with us please! I'm using gBridge for a while and i was very happy with this project. Too bad the project is dead i found it the best solution.

regards Marcel.

— Reply to this email directly, view it on GitHub https://github.com/kservices/gBridge/issues/56#issuecomment-1411170450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJPTY5GX5QWPK2K5YIMLCLWVGILZANCNFSM4TPJMTIA . You are receiving this because you were mentioned.Message ID: @.***>

MrMarcel66 commented 1 year ago

Hi Bert, thanks for sharing. I see if i can use the code, i'm not a programmer so fingers crossed. I'm using the gbridge docker setup. I was already moving from domoticz to homeassistant. But i have to stay on domoticz because the gbridge solution gives me more voice options, like using a pin for random devices and change switch devices to lights and when saying switch all lights off not all your switches wil turn off for example. Regards, Marcel.