While investigating a compile problem I noticed that your build was ignoring the CFLAGS and CXXFLAGS I had specified and using only its own (-Wall). This fixes it by prepending -Wall to the user flags rather than overwriting them. This allows the user to override your flags at the command line if they want to.
I also separated the C and C++ compiler checks. You were only checking if the C++ compiler is clang and using that result to decide what to do for both the C and C++ compiler. Now each is checked and handled individually.
ksherlock
commented
1 year ago
While investigating a compile problem I noticed that your build was ignoring the CFLAGS and CXXFLAGS I had specified and using only its own (
-Wall). This fixes it by prepending-Wallto the user flags rather than overwriting them. This allows the user to override your flags at the command line if they want to.I also separated the C and C++ compiler checks. You were only checking if the C++ compiler is clang and using that result to decide what to do for both the C and C++ compiler. Now each is checked and handled individually.