search

ksheumaker / homeassistant-apsystems_ecur

Home Assistant custom component for local querying of APSystems ECU-R Solar System
Apache License 2.0
186 stars 43 forks source link

Enhancement: Add inverter serial number to attributes #237

Closed wirecuttr closed 9 months ago

wirecuttr commented 9 months ago

Fixes #236

HAEdwin commented 9 months ago

Good addition! Three minor changes I'd like to suggest:

  1. Use "Inverter UID" instead of "Inverter Serial" because APSystems product manuals and online videos always use the term UID.
  2. Change the order to: ECU ID, Inverter UID, Last Update.
  3. Because ECU is an abbreviation for Energy Communication Unit we might as well immediately include this "ECU ID" instead of "Ecu ID".
wirecuttr commented 9 months ago

Good addition! Three minor changes I'd like to suggest:

  1. Use "Inverter UID" instead of "Inverter Serial" because APSystems product manuals and online videos always use the term UID.
  2. Change the order to: ECU ID, Inverter UID, Last Update.
  3. Because ECU is an abbreviation for Energy Communication Unit we might as well immediately include this "ECU ID" instead of "Ecu ID".

Hi, I'm pretty new to GitHub and also pretty new to Home Assistant. I'm not clear what you mean by number 3. As I understand it, the attributes are always in lower case and without spaces in Home Assistant. Am I missing something?

HAEdwin commented 9 months ago

Thank you for the addition.