search

kshitij10496 / hercules

The mighty hero helping you build projects on top of IIT Kharagpur's academic data
https://hercules-10496.herokuapp.com/api/v1/static/index.html
MIT License
34 stars 18 forks source link

Use dep as the dependency manager #13

Closed icyflame closed 5 years ago

icyflame commented 5 years ago

Makefile is a convenience feature - you can run commands like make docker/build after writing them once inside the Makefile. It's also very useful for new users who don't quite know where to begin.

kshitij10496 commented 5 years ago

This is great! I tried using dep for managing Go packages. However, it seemed to me that Heroku doesn't yet support it. Hence, I reverted to godep.

icyflame commented 5 years ago

@kshitij10496 Oh! Didn't know that. Feel free to just reject this PR in that case (been developing with Docker and Kubernetes lately, so I didn't consider Heroku support.

A cursory look at the Heroku page for support seems to show that dep is supported through the community. here. Since this is a basic setup in this application, we shouldn't run into any problems. You can consider using it. 🙂

kshitij10496 commented 5 years ago

A cursory look at the Heroku page for support seems to show that dep is supported through the community. here. Since this is a basic setup in this application, we shouldn't run into any problems. You can consider using it.

Awesome! Let's give dep a try. 🎉 Let me know if this branch is ready for testing and deployment. 😄

icyflame commented 5 years ago

@kshitij10496 Cool! I will update my branch to the latest master and put these changes in and ping again. 🙂

icyflame commented 5 years ago

@kshitij10496 It's fine to merge now. I just did dep ensure -v after rebasing to the latest master.

kshitij10496 commented 5 years ago

dep is live! 🕶 :party_parrot:

I just had to add some metadata in Gopkg.toml in order to get it working.

Refer: Build Configuration