Rename the environment variable to DATABASE

kshitij10496 / hercules

The mighty hero helping you build projects on top of IIT Kharagpur's academic data

https://hercules-10496.herokuapp.com/api/v1/static/index.html

MIT License

34 stars 18 forks source link

Rename the environment variable to DATABASE #15

Closed kshitij10496 closed 5 years ago

kshitij10496 commented 5 years ago

The MVP of hercules used DATABASE_URL environment variable for the DB connection string. Thanks to #6, we are now using envconfig for the management of configuration values. Currently, the developer is required to set HERCULES_DATABASEURL for the same DB connection.

It would be aesthetically pleasing if someone can rename the variable to HERCULES_DATABASE instead.

mels065 commented 5 years ago

I'll give it a go

kshitij10496 commented 5 years ago

@mels065 It seems @geektimus has already opened a PR with a fix. However, there are a lot of other issues that you might be interested in. Do check them out and ask for help! 😄