Rename the environment variable to DATABASE

kshitij10496 / hercules

The mighty hero helping you build projects on top of IIT Kharagpur's academic data

https://hercules-10496.herokuapp.com/api/v1/static/index.html

MIT License

34 stars 18 forks source link

Rename the environment variable to DATABASE #18

Closed geektimus closed 5 years ago

geektimus commented 5 years ago

Fixes #15

kshitij10496 commented 5 years ago

Good work @geektimus I will wait for another review before merging this in. 😄

cc @icyflame @themousepotato @Ayushk4 @thealphadollar

kshitij10496 commented 5 years ago

@icyflame The testing (primarily handler tests) is rather naive and preliminary at the moment. I'm still reading about the best practices for testing APIs with DB interactions. Having said that, I agree with you that the variables shouldn't be hardcoded for testing. We will most definitely use envconfig in tests as well. 😅