search

kshitij10496 / hercules

The mighty hero helping you build projects on top of IIT Kharagpur's academic data
https://hercules-10496.herokuapp.com/api/v1/static/index.html
MIT License
34 stars 18 forks source link

Add landing page #19

Closed rasfa98 closed 5 years ago

rasfa98 commented 5 years ago

landing-page

kshitij10496 commented 5 years ago

Hey @rasfa98 😄 This looks great! Almost as minimal as it can get.

Just a couple of suggestions:

rasfa98 commented 5 years ago

@kshitij10496 Thanks! I will fix it according to your suggestions! 😄

rasfa98 commented 5 years ago

landing-page-2

kshitij10496 commented 5 years ago

Waiting on another +1 before merging this in!

cc @icyflame @Ayushk4 @themousepotato @thealphadollar

thealphadollar commented 5 years ago

LGTM too :+1:

@rasfa98 It would be great if you add the mechanism to deliver the page when someone opens the url /api/v1.

This might help, https://stackoverflow.com/questions/26559557/how-do-you-serve-a-static-html-file-using-a-go-web-server

The reason why I would like it to be the landing page for /api/v1 and not / is that in future we may have more versions of the API and different landing pages for them.

rasfa98 commented 5 years ago

I have never written anything in GO but I will give it a shot! 😄

thealphadollar commented 5 years ago

I guess that's even better then :smile:

rasfa98 commented 5 years ago

@thealphadollar It may be a better idea if someone with a bit more experience with GO could fix this since I do not have time to setup the environment right now 😄 You could merge this PR and then open a new issue 😃

kshitij10496 commented 5 years ago

@rasfa98 @thealphadollar I will open a new issue for adding a handler in order to render the static page. 😃 Merging this in!