search

kshitij10496 / hercules

The mighty hero helping you build projects on top of IIT Kharagpur's academic data
https://hercules-10496.herokuapp.com/api/v1/static/index.html
MIT License
34 stars 18 forks source link

Setting Content-Type Response Header #30

Closed eransevi closed 5 years ago

eransevi commented 5 years ago

Explicitly setting Content-Type to application/json for all successful json responses

Fix for #29

kshitij10496 commented 5 years ago

Thanks @eransevi for the fix! 😄

thealphadollar commented 5 years ago

LGTM too, nothing can be done wrong in a line. :+1:

kshitij10496 commented 5 years ago

This is in! Kudos @eransevi 🎉

kshitij10496 commented 5 years ago

@thealphadollar This is what I think whenever there is a "one-line" change. https://twitter.com/bradfitz/status/1054905211372822528

TODO: Assert HTTP response headers in tests 😅