search

kshitij10496 / hercules

The mighty hero helping you build projects on top of IIT Kharagpur's academic data
https://hercules-10496.herokuapp.com/api/v1/static/index.html
MIT License
34 stars 18 forks source link

Hercules application error on heroku, app not working #42

Closed Ayushk4 closed 5 years ago

Ayushk4 commented 5 years ago

https://hercules-10496.herokuapp.com/api/v1/department/info/all Tried, various links, none works.

kshitij10496 commented 5 years ago

I don't know why but the app crashed possibly due to some Heroku issue. It should be working after a quick dyno restart. 😅

Ayushk4 commented 5 years ago

@kshitij10496 It crashed again :sweat_smile: . It seems that the 404 handler is not working.

I request for a course code that did not exist (accidentaly) : https://hercules-10496.herokuapp.com/api/v1/course/timetable/MA6102 , after which it crashed.

kshitij10496 commented 5 years ago

Got the bug!

I have used log.Fatal for debugging invalid requests. 🙈 This is causing the app to crash when the user is making invalid requests. All the logs should be log.Print for now.

Making a quick fix to master.

Ayushk4 commented 5 years ago

I will keep finding bugs to bother you :stuck_out_tongue: .

Ayushk4 commented 5 years ago

It shows internal server err : 500 instead of bad request or 404.

kshitij10496 commented 5 years ago

I will keep finding bugs to bother you 😛 .

That's actually great! I think those would be good places to get started with contributing to the API server.