search

kshitij10496 / lexico

CLI to familiarize you with those elusive words
MIT License
22 stars 12 forks source link

Add links to US and UK audio pronunciations #2

Open kshitij10496 opened 6 years ago

kshitij10496 commented 6 years ago

Currently, only the link to US pronunciation is displayed. Explore Wordnik API for relevant options.

priyanshsaxena commented 6 years ago

From Wordnik Developer - API Docs

Currently only audio pronunciations from the American Heritage Dictionary in mp3 format are supported.

Possible options are:

  1. Macmillan Dictionary API
  2. Oxford Dictionaries API
priyanshsaxena commented 6 years ago

@kshitij10496 I am looking to use Merriam-Webster Collegiate Audio Pronunciation API for adding the relevant pronunciation. This would require adding my API key to config.json file. I am planning to change the *_api_key methods in utils.py. What is your opinion on this ?

kshitij10496 commented 6 years ago

I was thinking of labeling the API response from Wordnik as US or UK pronunciation. Merriam-Webster API is not developer friendly due to the use of XML. Moreover, I don't see the distinction between pronunciation type in that API as well.

Since this is a low priority feature, we can skip it for now and work on the more demanding issues.