search

kshitij86 / wine-app

Short video app, built with React Native ⚛️
7 stars 3 forks source link

Add a splash screen #2

Closed kshitij86 closed 4 years ago

kshitij86 commented 4 years ago

To enhance the user experiece, add a splash screen following the app colors and style.

Xaconi commented 4 years ago

Hi! Can I get assign on this one?

kshitij86 commented 4 years ago

Your contribution is welcome @Xaconi

This has been assigned to you. Feel free to ask if you have any questions!

RudrakshK commented 4 years ago

Hi! Could I be assigned this issue ? PS: I am from reddit ;)

kshitij86 commented 4 years ago

@Xaconi you used the provided splash from the assets. I've tried using that one, it is not properly cropped and stretches too far on Android devices. We need a splash image that scales with device screen size (an SVG maybe?) using the same design as splash.png. Let me know if you have any queries regarding this.

kshitij86 commented 4 years ago

@RudrakshK sure! Your contributions are welcome. Assigning this to you as well.

Xaconi commented 4 years ago

@Xaconi you used the provided splash from the assets. I've tried using that one, it is not properly cropped and stretches too far on Android devices. We need a splash image that scales with device screen size (an SVG maybe?) using the same design as splash.png. Let me know if you have any queries regarding this.

Ok I'll try with an SVG. But the image of the splash screen I use is a modified one. Can you share a screenshot of an Android device on the splash screen?

EDIT: I attach an image how I see the splash screen on an iPhone

image

kshitij86 commented 4 years ago

Here. This is what it looks like.

The font is jagged and the text is too big.

wine

kshitij86 commented 4 years ago

I guess it looks better on a larger display. Which device are you using @Xaconi ?

Xaconi commented 4 years ago

I guess it looks better on a larger display. Which device are you using @Xaconi ?

I'm using an iPhone SE (it's like an iPhone 5, kind of small). But it looks like (on the screenshot you post) when I have the splash image with the old asset. You're using the new one?

Xaconi commented 4 years ago

I guess it looks better on a larger display. Which device are you using @Xaconi ?

@kshitij86 any updates on this?

kshitij86 commented 4 years ago

@Xaconi The screenshot @RudrakshK posted seems to render properly. Once he makes the necessary changes, I guess we'll go with that. I've labelled both PRs as hacktoberfest-accepted though.