search

kshitijyelpale / blockchain-hyperledger-fabric-electronic-patient-records

GNU General Public License v3.0
49 stars 43 forks source link

Changed default basics for chaincode in deployCC file #13

Closed kshitijyelpale closed 3 years ago

kshitijyelpale commented 3 years ago

Just changed default values in deployCC to get cahincode

kshitijyelpale commented 3 years ago

Task linked: CU-c0vm02 Bug: Corect DeployCC default values for chaincode

sjathin commented 3 years ago

Why are there extra commits here ?

kshitijyelpale commented 3 years ago

I rebased the main branch to my branch and varsha's changes are visible here. In the GIT history I can see only my change but here on GITHUB File Changed, it is showing 10 files changed 1 of mine and 9 of varsha's. Not getting why is that.

image

sjathin commented 3 years ago

I did a similar mistake last time. The new branch that you created must be first synced with main(remote). Then Publish the branch. Please revert this PR. And try to create a new branch synced with the main(remote) and then push to your branch (remote).

kshitijyelpale commented 3 years ago

For sync only, I rebase with "main" branch. And even after the merge process, the commits are fine. If you see git history then for my commit it is showing only 1 commit (file change).

Another point is if I reopen, delete the branch and create new, still, the state will be the same as of now. Something goes wrong in rebase I know that but files are properly synced now. I'll be more careful next time. No need to do anything I think. Do you find anything wrong please raise it.