Closed varshakamath1 closed 3 years ago
Hi,
- There are still some functions which are duplicate in multiple classes, which restricts us to reuse the single piece of code.
- I suggested some structuring changes in What's app group chat. Has it some problems with that or any limitations?
- I am sorry for the comments, but the things can be improved :) If you find this a bit difficult I can do that or help you in that.
Changing into a single piece of code cannot be done because -
Hi Varsha,
- I practiced some OOPS concept here in this smart contract hierarchy. Check it out and tell me how's it and now code a bit reusable ;)
- I attached patch file (created on your branch) to the ticket, as it is not possible to attach the patch file here.
- I have some doubts, like in getAllPatientResults() why you stored values in jsonRes.Value when history flag enabled and jsonRes.Record. when false. I tried with storing in Record and it worked. You skipped patient id when history is enabled. Is there any reason? We can revert that if we are breaking with unifying to Record.
- BTW parent functions can not be called unless the functions definition specified child classes with Super keyword. I observed that oops concepts are not mature in JavaScript unlike other Programming languages
@kshitijyelpale: I am not able to find the patch file in my branch.
Yes, I noticed it too, So, I have already changed jsonRes.Value to jsonRes.Record and added patient Id as well. It will be visible in the next commit.
Patch is attched to the ticket.
Hi Varsha,
- I practiced some OOPS concept here in this smart contract hierarchy. Check it out and tell me how's it and now code a bit reusable ;)
- I attached patch file (created on your branch) to the ticket, as it is not possible to attach the patch file here.
- I have some doubts, like in getAllPatientResults() why you stored values in jsonRes.Value when history flag enabled and jsonRes.Record. when false. I tried with storing in Record and it worked. You skipped patient id when history is enabled. Is there any reason? We can revert that if we are breaking with unifying to Record.
- BTW parent functions can not be called unless the functions definition specified child classes with Super keyword. I observed that oops concepts are not mature in JavaScript unlike other Programming languages
@kshitijyelpale: I am not able to find the patch file in my branch.
Yes, I noticed it too, So, I have already changed jsonRes.Value to jsonRes.Record and added patient Id as well. It will be visible in the next commit.
@kshitijyelpale Thank you for the help :)
Hi Varsha,
- I practiced some OOPS concept here in this smart contract hierarchy. Check it out and tell me how's it and now code a bit reusable ;)
- I attached patch file (created on your branch) to the ticket, as it is not possible to attach the patch file here.
- I have some doubts, like in getAllPatientResults() why you stored values in jsonRes.Value when history flag enabled and jsonRes.Record. when false. I tried with storing in Record and it worked. You skipped patient id when history is enabled. Is there any reason? We can revert that if we are breaking with unifying to Record.
- BTW parent functions can not be called unless the functions definition specified child classes with Super keyword. I observed that oops concepts are not mature in JavaScript unlike other Programming languages
@kshitijyelpale: I am not able to find the patch file in my branch. Yes, I noticed it too, So, I have already changed jsonRes.Value to jsonRes.Record and added patient Id as well. It will be visible in the next commit.
@kshitijyelpale Thank you for the help :)
Welcome
Task linked: CU-cv35qe Creation of Admin smartcontract and structuring SC