kshnurov / mandrill_dm

A basic Mandrill delivery method for Rails.
MIT License
46 stars 45 forks source link

Are you alive? :) #4

Closed kshnurov closed 9 years ago

kshnurov commented 10 years ago

Maybe you'll transfer this repo to me? I'll continue support and merge pull requests.

spovich commented 9 years ago

+1

nadavshatz commented 9 years ago

+1

mataki commented 9 years ago

+1

mahm commented 9 years ago

+1

RobertoSchneiders commented 9 years ago

:+1:

kimrgrey commented 9 years ago

:+1:

jlberglund commented 9 years ago

Alas, I am still alive. :) Sorry folks. It's been busy, and I've obviously been neglecting this. I'm leaving my current employer in the next week, so I hope to have more time for this after the new year. I'm also open to adding developers to the repo. I'll review and get back to you. You can haunt me on Twitter (@jlberglund) if I fail once again to respond.

kshnurov commented 9 years ago

Ok, could you please add me as a developer?

icem commented 9 years ago

Does anyone have a good fork already?

jlberglund commented 9 years ago

Okay all. There's a resurrection going on. @kshnurov and @spovich have been added as collaborators. :)

kshnurov commented 9 years ago

Thank you, @jlberglund!

jlberglund commented 9 years ago

@kshnurov thanks for your help! A few things going forward though:

Here's the workflow I follow: http://www.joslynesser.com/blog/archives/2010/09/06/git-workflow-for-small-teams/ . What do you think? @spovich did I miss anything?

spovich commented 9 years ago

@jlberglund Yes, agreed on first two points. On the third point, I'm not convinced of the need for a dedicated development branch. Maybe you can convince me :)

I think the you should consider gems and continuously deployed apps as different creatures. For continuously deployed apps, I think a development branch can be useful (as indicated in the article), but for a gem with only periodic releases, I think it is ok to treat master as the latest approved features where features/bugs are branched off latest master. Then, when feature branches off of master are properly rebased, and have requisite +1's, they are merged to master. Also, I don't anticipate this to be a fast-moving project.

Gem releases are done when we think that enough bug fixes/features warrant a release. I would assume that @jlberglund will handle gem releases and update the changelog accordingly.

jlberglund commented 9 years ago

@spovich I agree.

The main thing for me is that development is branched off. So we can revise it that way. I don't want half-features or half-fixes on the master branch.

spovich commented 9 years ago

@jlberglund Totally! A PR needs to stand on it's own as a full feature/bugfix.

jlberglund commented 9 years ago

@spovich Sounds good. I've updated the Wiki page for this repo, but feel free to adjust anything I missed or anything you feel is pertinent.

@kshnurov Do you have a way to stay in contact? Twitter maybe?

kshnurov commented 9 years ago

Guys, @spovich , @jlberglund , you're talking about one little gem like it's a starship for interstellar travel :) Keep it simple.

  1. We should have a deadline. If no one is responding for more than a week, one +1s should be enough. Other way we can wait for another 4 months, like we waited for this issue. 2 & 3. Ok!

About releases: what's wrong with releasing minor version after adding some feature? Once again, it's not a starship, we can spend half a year waiting for something we think is "enough". It's just a mailer.

@jlberglund , if you'll handle releases, can you handle them a bit quicker than this issue? :) It's easier to contact with me by email.

spovich commented 9 years ago

@kshnurov following good development practices does not make an interstellar starship. Please avoid insulting hyperbole, that doesn't help.

If we can't get two +1's from maintainers in a reasonable time, we need new maintainers. Having said that, I like vacations and so there will be weeks when I don't respond. If responsiveness becomes a problem going forward, we can deal with that. No need for arbitrary date cutoff rules.

Regarding releases, we are saying the same thing. If there are new features or bugfixes, then we should release a gem. I assume once we clear the backlog, things will settle down. However, we first need to get 'master' squared away as things are broken right now from your merges.

spovich commented 9 years ago

@kshnurov @jlberglund Ok, I've reverted the commits that broke the tests on master, so master is passing for me now. @kshnurov please open new PR's or update those so tests are good. I'm going to add Travis so we can have better visibility on the tests.

jlberglund commented 9 years ago

Thanks @spovich. @kshnurov I hear you, but I'm using the gem in an important app. I can't update the gem unless it passes all tests.

I agree with @spovich - we need two +1s.

jlberglund commented 9 years ago

@kshnurov if there are any features you want to push through sooner rather than later, will you open issues for them? that might help us prioritize and ensure you get the faster results you're looking for. Also, what's your email address? Thanks!

kshnurov commented 9 years ago

@jlberglund , I'll figure that out in a few days, we're currently integrating this gem into our app. My email is k [at] zx0.ru