search

kshnurov / mandrill_dm

A basic Mandrill delivery method for Rails.
MIT License
46 stars 45 forks source link

Send all passed headers to Mandrill #51

Closed Tensho closed 7 years ago

Tensho commented 7 years ago

Fixes #20

Tensho commented 7 years ago

@kshnurov, what's wrong with Rubocop? I passed all checks locally, but failed at CI.

kshnurov commented 7 years ago

@Tensho new Rubocop rule Metrics/BlockLength didn't ignored specs. Fixed that.

LGTM. @spovich any thoughts?

dorongutman commented 7 years ago

@Tensho I think you meant it fixes #50

spovich commented 7 years ago

Looks good to me! Nice fix!

spovich commented 7 years ago

@kshnurov I'll do a new release tonight if there are no objections.

Tensho commented 7 years ago

@dorongutman, yeah, right #50, sorry, was in rush, due to bad Internet connection.