kshnurov / mandrill_dm

A basic Mandrill delivery method for Rails.
MIT License
46 stars 45 forks source link

Move mail gem to runtime dependencies #52

Closed Tensho closed 7 years ago

Tensho commented 7 years ago

I noticed, that mail gem is declared as a development dependency, but actually mandrill_dm gem doesn't make sense without it in runtime. It means, if you bundle some app with gems, that don't have mail gem as a dependency by themselves (like rails), you will get error. So when you declare gem as a runtime dependency, it will be automatically placed to the default bundler group and accessible out of the box.

kshnurov commented 7 years ago

LGTM