search

kshyju / BrowserDetector

Fast & light weight browser detection & device detection for asp.net core and azure functions
MIT License
30 stars 13 forks source link

Add support for 2 User-Agents #2

Closed ricovivid closed 4 years ago

ricovivid commented 4 years ago

Hello,

Could you add support for the following User Agents:

docker/19.03.5 go/go1.12.12 git-commit/633a0ea kernel/4.9.184-linuxkit os/linux arch/amd64 UpstreamClient(Docker-Client/19.03.5 \(windows\)) PostmanRuntime/7.21.0 < not sure if this one is possible since there is no indication of OS

I didn't look much at the code after I read your statement about opening a ticket to request more browser/os combos, but I suppose I could take a stab at forking and adding them, if you couldn't.

Thanks!

kshyju commented 4 years ago

Hey, Thanks!

Curious to know what platform these UAs will result in ?

kshyju commented 4 years ago

What browser it will / should resolve into ?

ricovivid commented 4 years ago

Sorry for the late reply. If it is the Docker-Client UA it should resolve to Docker-Client. If it is the Postman UA it should resolve to Postman.

kshyju commented 4 years ago

The goal of the library is to enable light weight pure browser detection. Docker-client in this case is not a pure browser/UA. Isn't it ?

ricovivid commented 4 years ago

Sorry, I wasn't aware of the purpose of that goal. I will roll my own, thanks.

On Tue, Feb 25, 2020, 1:48 AM Shyju notifications@github.com wrote:

The goal of the library is to enable light weight pure browser detection. Docker-client in this case is not a pure browser/UA. Isn't it ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kshyju/BrowserDetector/issues/2?email_source=notifications&email_token=AALHIZCCVMFWCSAMPEZXLS3RES5KZA5CNFSM4KLO7YF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM2YUSI#issuecomment-590711369, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALHIZHFUQCRQII45XXXMTLRES5KZANCNFSM4KLO7YFQ .