search

ksindi / implements

:snake: Pythonic interfaces using decorators
http://implements.readthedocs.io/
Apache License 2.0
33 stars 4 forks source link

A few improvements #5

Closed pshirali closed 4 years ago

pshirali commented 4 years ago

Hello @ksindi ,

First, let me thank you for this amazing library. I really hope this library is used by the masses.

I created two PRs. One of them is a minor cosmetic fix. The other includes changes to the tests and a few additions as well. The PRs have failed during CI for different reasons. This gives us a chance for you to review them, and for me to make amends to resubmit the PRs.

PR #3 appears to have failed due to CI runtime. I might have to create a new commit and repush.

PR #4 has failed deepsource checks. Please feel free to review the deepsource results. I'm of the opinion that tests.py could additionally be excluded using exclude_patterns in the .deepsource.yaml file. There will likely be future failures reported on test-code when we intentionally write code that matches a bad pattern. Further, improvements to deepsource may flag existing test-code in future PRs.

Please let me know your views.

Cheers, Praveen

ksindi commented 4 years ago

Thanks @pshirali! Much appreciated. Will review and release this week.

ksindi commented 4 years ago

@pshirali changes released. Thanks again.

pshirali commented 4 years ago

Thanks @ksindi :)

PS: I noticed that you've +1'd the python minor version in multiple files. You missed setup.py.

ksindi commented 4 years ago

Oops. Thanks. Fixing.