ksingh7 / odf-nano

ODF-Nano lets you deploy OpenShift Data Foundation on your Laptop (CRC)
44 stars 29 forks source link

Breaking out the YAML? #22

Open kenmoini opened 3 years ago

kenmoini commented 3 years ago

As I take a look at the deployment script, none of the inline EOF'd YAML seems to use any Bash variable substitution/templating - what's the thought around breaking out that YAML into their own files to be oc apply -f'd and provide for use in other automation workflows? Also has the benefit of making the deployment script a bit more atomic and easy to maintain/iterate...I'd be happy to submit that PR once Tosin's patches are merged, to avoid any potential merge conflicts.