ksivasenthil / GreenBox

Solution to put CO2 emission on a route
0 stars 0 forks source link

Fix the layout on the page #2

Open ksivasenthil opened 9 years ago

ksivasenthil commented 9 years ago

When viewed in a small device, the page has controls kissing each other. The route suggestion is displayed, the text for navigation overlaps with the circle displaying the CO2 emission.

Sub tasks for this issue are -

ironicicon commented 9 years ago

Siva, Can you share the azure link?... (i have created index.html in my local machine and let me know is this the issue you are talking about, (part of the issue though;) ) image

ksivasenthil commented 9 years ago

:+1: indeed. it is just one issue. The other one is to do with

image

Look @ the bottom navigation instructions which overlap if the text is too large.

ironicicon commented 9 years ago

I am taking Care of it..let me complete this Task first

ironicicon commented 9 years ago

Shiva, I have found a fix for the issues mentioned, kindly look into the below screenshots.

kissing

overlappingissue

ksivasenthil commented 9 years ago

@ironcicon, have you hosted the changes to azure? I do not see the changes when I browse greendrive.azurewebsites.net

ksivasenthil commented 9 years ago

@ironcicon please commit your changes. Let us use features of Git for code control.

ksivasenthil commented 9 years ago

@ironicicon, I have made some changes to the styles for the input control zone. Changes are checked-in. I am not sure if the experiment that you have done with Chrome is similar to that or different.

Do send me your observations. For the text overlap in the step instruction, I have noticed, the markup is generated by the google maps service. Do you have plans to do something to the markup or is there any other way out?

Let me know your thoughts.

ironicicon commented 9 years ago

@ksivasenthil I havent checked in, since i assumed that you were mentioning about versioning.. My Bad.. I will look at the greenbox and will update the same..

ksivasenthil commented 9 years ago

@ironicicon please do check again, one more came through ;). This one was for the navigation instruction. :smile:

ironicicon commented 9 years ago

I was trying to add the (...) "trimmed content" to the navigation Instruction, but i was not able to pull it off.. It seems that , when i click on the trimmed content, i was shown an instruction on the map with the same trimmed Instruction ( i was having "read More" instead of (...) )

image

ksivasenthil commented 9 years ago

@ironicicon the problem you faced might have been because of you modifying the html content from the api. Instead of editing the only copy, you use a CSS transform or try to have a copy with all the text and one for display with the (...),

I would not recommend "Read More" since, this might add more navigation in the frame which is already small.