search

kski2 / myShoppingApp

An app that forms you a shopping list
0 stars 0 forks source link

Snazzy app! #1

Open danieljamesross opened 3 years ago

danieljamesross commented 3 years ago

Wow, what a cool app!

One possible improvement:

kski2 commented 3 years ago

Hi Dan,

Yeah about the checkboxes, I just got stuck as I added some bootstrap to them but firstly I don’t think it works, and secondly I can’t figure out how to make them be on the same line as the products.

Got any clues how I can improve it?

Thanks Kacper On Tue, 17 Nov 2020 at 7:43 pm, Dan notifications@github.com wrote:

Wow, what a cool app!

One possible improvement:

  • I am not quite sure what the checkboxes are for (maybe for ticking off the list?), but if they relate to each of the added items, then maybe try to use CSS so that they align next to the correct item.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kski2/myShoppingApp/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARRHN25RCTQ6Q4GHXAYZDHLSQLG63ANCNFSM4TZAOP5A .

danieljamesross commented 3 years ago

Try adding the item and the checkbox inside the same element, something like:

<li>New Item - <checkbox /></li>

kski2 commented 3 years ago

Alright I’ll try and experiment with that, thanks!

On Tue, 17 Nov 2020 at 7:56 pm, Dan notifications@github.com wrote:

Try adding the item and the checkbox inside the same element, something like:

  • New Item -

    • — You are receiving this because you commented.

    Reply to this email directly, view it on GitHub https://github.com/kski2/myShoppingApp/issues/1#issuecomment-729166349, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARRHN24AURCHSH4DFYD44LDSQLIPJANCNFSM4TZAOP5A .