ksobon / MantisShrimp

A interop project for bridging the gap between Rhino/Grasshopper and Revit/Dynamo
37 stars 9 forks source link

Multi Span Nurbs Curves in Breps/PolyCurves vs. stand alone Nurbs #11

Open ksobon opened 9 years ago

ksobon commented 9 years ago

It seems like there is no need to check Nurbs Curves for spans unless they are part of a Trim Loop or came from a PolyCurve that then needs to be joined together in Dynamo. This causes problems like almost every Nurbs Curve that get's passed in from Rhino returns true for multiple spans and gets re-created as a polycurve instead of nurbs curve. Objective: Only check Nurbs Curves for spans when dealing with Breps/PolyCurves and omit that check for regular curves. Possible Problems: Dynamo G1 Discontinuity is a real problem here. Let's make sure that that doesn't throw off the translation. Things to consider: If curves are meant to interop with Revit API they really have to be Degree 3 or Revit will reject them. Also, multi span nurbs will not work here because they end up being PolyCurves. Keep that in mind.