search

ksobon / MantisShrimp

A interop project for bridging the gap between Rhino/Grasshopper and Revit/Dynamo
37 stars 9 forks source link

Select Rhino Geometry does not translate into DS Geometry #18

Closed jluebker closed 8 years ago

jluebker commented 8 years ago

@ksobon, i'm finding a few instances where some Rhino geometry does not translate into DS geometry by any of the conversion methods. so far i've only seen this happening with select Breps. I am able to bring them into dynamo using an SAT import though.

I've attached a screen shot of the issue as well as the rhino file, sat file and dynamo file im using.

ms-bug

MS-Breps.zip

ksobon commented 8 years ago

I will have a look at this...hopefully this week. Thanks for posting.

jluebker commented 8 years ago

Cool thank you, no rush. I was just trying an alternate workflow to the SAT process I’ve been working with.

ksobon commented 8 years ago

So far I have been able to narrow it down to an error that Dynamo throws:

StandardError: Unable to create face from spline : IG_SURFACE_IRREGULAR -- Irregular Surface

This looks to be a Dynamo limitation, but I want to find out what surface specifically causes that error and why would they flag it as "irregular", maybe there is something that we can do to "fix them" in Rhino.

I will keep you in touch.

jluebker commented 8 years ago

I was thinking about this last night a bit. The geometry that fails is a torus I used the twist command on in rhino. I can try replicating it with an un-modified torus as well. Ironically though, the other two complex shapes also were modified with the twist command in rhino and they worked fine.

jluebker commented 8 years ago

Ok it appears that a torus will work as does modifying a torus with anything but the twist command. It seems that the twist does something to a torus that throws the error you see and dynamo does not like it.

ksobon commented 8 years ago

Ok, I am not sure how you created this, but that thing was nasty. It had self intersections that were throwing Dynamo off. I am usually pretty cool with people making funky shapes and trying to use them to "test" Mantis Shrimp, but dude this surface is a definition of how you should NOT model in Rhino. I don't see a point in trying to translate that to any other software.

Still, I got it translated, but only after I re-created that one troublesome surface.

image

ksobon commented 8 years ago

BTW, the rest of them worked fine too. I did re-build the two twisted torus shapes but i don't think it was actually necessary.

image

jluebker commented 8 years ago

That’s actually not the one that fails in my graph… it’s the torus I used the twist command on in rhino. I know that surface has self-intersecting geometry and it was purposeful. I was fully trying to compare the capabilities of importing geometry into dynamo using mantis shrimp compared to the SAT option. I was purposefully trying to break it so I know the limits before I deploy this to the office as a stable way of importing rhino geometry into revit for those who do not understand the finer points of 3d modeling. I doubt any one will use a torus so I think we are ok they but I do some times see intersecting surfaces…

jluebker commented 8 years ago

Interesting… ok good to know that rebuilding in rhino will fix this… thanks for looking into it and sorry for the hassle.