search

ksoichiro / dockerfiles

Dockerfile examples.
54 stars 22 forks source link

switched to https for google downloads #1

Closed marcograss closed 10 years ago

ksoichiro commented 10 years ago

Thank you for your feedback! But.. could you tell me the reason to use https?

Of course, maybe it's better to use https but I couldn't build these Dockerfiles successfully any more due to obsolete package filters.

Error: Ignoring unknown package filter 'build-tools-19.0.3'
:
Max number of retries exceeded. Rejecting 'android-sdk-license-5be876d5'
Package Android SDK Platform-tools, revision 20 not installed due to rejected license 'android-sdk-license-5be876d5'.
Package SDK Platform Android 4.2.2, API 17, revision 2 not installed due to rejected license 'android-sdk-license-5be876d5'.

Obviously this is a different problem but it must be fixed to use your modification.

marcograss commented 10 years ago

Hi, thanks for getting me back,

I proposed this modification because when I use development tools or in general software, I try to stick as much as possible to https for security. If you download packages, especially with executables inside, you can get mitm'd and your package can be altered and code get executed in your system (well in this case inside your container) (in some countries of the world, unfortunately it's done on a daily routine for surveillance).

ksoichiro commented 10 years ago

Thanks, I understood. As I said, the problem of package filtering error is not related to your fix so I'll merge your modification and manage the problem in other issue(#2).