ksons / gltf-blender-importer

Blender glTF 2.0 Importer
MIT License
214 stars 36 forks source link

Implement morph targets #32

Closed scurest closed 6 years ago

scurest commented 6 years ago

A somewhat hacky implementation of morph targets

Are morph targets the last major feature we're missing? I think this will make everything in base glTF implemented in some form, though not necessarily implemented without any bugs ;)

(This is implemented on top of #31 and its history should look better if that is merged).

scurest commented 6 years ago

The latest commit is slightly less hacky (or rather, the hack is now contained in a single function). There is now one bmesh that we use throughout all mesh creation and no more round-tripping. This requires re-labelling the vertex indices, but after the fix for #29 we already do that. As a bonus, it shaves about 2-3 seconds off the import time for MetalRoughSpheres for me.

ksons commented 6 years ago

@scurest Looks amazing! Could you please fix the conflicts or base the changes on the previous merge?

scurest commented 6 years ago

If you had done a regular merge of #31 like I asked it wouldn't need to be rebased. I don't see why I should have to rebase after every single PR.