kspalaiologos / kamilalisp

A functional, flexible and concise Lisp.
GNU General Public License v3.0
275 stars 10 forks source link

Build failed; edits to get it to build #83

Closed windwardly closed 8 months ago

windwardly commented 8 months ago

I had trouble building, getting 4 errors.

I'm running:

$ mvn --version
Apache Maven 3.6.3
Maven home: /usr/share/maven
Java version: 17.0.10, vendor: Debian, runtime: /usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.10.0-28-amd64", arch: "amd64", family: "unix"

One of the errors:

$ mvn package
[..]
ERROR [..]/kamilalisp/src/main/java/palaiologos/kamilalisp/runtime/dataformat/archive/ZipCreate.java:
[88,42] incompatible types:
    org.apache.commons.compress.archivers.ArchiveEntry
cannot be converted to
    org.apache.commons.compress.archivers.zip.ZipArchiveEntry

My edit:

-                    ArchiveEntry e = zaos.createArchiveEntry(f, entryName);
+                    ZipArchiveEntry e = zaos.createArchiveEntry(f, entryName);

And similarly, edits in 3 other files, and it builds.

Is there something I could have done to have it build without these edits?

kspalaiologos commented 8 months ago

No worries, it was just a dependency bump that broke something.

windwardly commented 8 months ago

Thank you!