search

ksprojects / protobuf-jetbrains-plugin

Protobuf Support for JetBrains IDEs
https://plugins.jetbrains.com/plugin/8277
Apache License 2.0
259 stars 46 forks source link

Applying multiple field options (or using commas) gets marked as a syntax error #149

Closed LethiferousMoose closed 4 years ago

LethiferousMoose commented 4 years ago

Describe the bug I began noticing this most frequently when using the third-party plugin protoc-gen-validate. This plugin has multiple field options, that can be applied in sequence as well as lists such as "in" and "not_in". These are all valid proto syntax and compile and generate normally, but the plugin marks them as issues once a comma is present.

To Reproduce Steps to reproduce the behavior:

  1. Install protoc-gen-validate plugin in a project (or create options that can be applied with commas)
  2. Apply field options that contain comments
  3. See red underlines

Expected behavior Red underlines will not be present for valid syntax

Screenshots image

Plugin (please complete the following information):

jvolkman commented 4 years ago

143 has some discussion on this.

LethiferousMoose commented 4 years ago

Thanks, I will just close my issue since it is the same.