ksqsf / emacsmoe

Emacs with Moe Visual Effects!
http://www.gnu.org/software/emacs/
GNU General Public License v3.0
12 stars 1 forks source link

Remove PoC Mac shadow rendering code #8

Closed jakeprime closed 3 days ago

jakeprime commented 3 days ago

The shadow rendering is already happening earlier in the macfont_draw function, and this code overrides it with the default, ignoring the styling.

jakeprime commented 3 days ago

Hi @ksqsf 👋🏻

I have been happily using a build with the shadow for ages on my Mac, but I had to rebuild from the latest head recently as my version of Emacs didn't have up to date compat libraries. But after rebuilding I didn't have any styled shadows any more.

I don't really know what I'm doing in this codebase, but this works for me, so hopefully all good.

ksqsf commented 3 days ago

Thanks! It's weird why the old code is there. Likely I did something wrong when doing git rebase...