search

kstenerud / KSCrash

The Ultimate iOS Crash Reporter
MIT License
4.26k stars 712 forks source link

Custom CrashInstallation - initWithRequiredProperties not exposed in public api #581

Closed MagdaSzlagor closed 3 weeks ago

MagdaSzlagor commented 1 month ago

Describe the bug

I'm trying to create a custom CrashInstallation. When I call init on this class I get a crash with message: KSCrashInstallation does not support init. Subclasses must call initWithRequiredProperties:

Steps to reproduce

  1. call CrashInstallation() <- KSCrashInstallation does not support init. Subclasses must call initWithRequiredProperties:
  2. try with CrashInstallation(requiredProperties: []) <- Argument passed to call that takes no arguments

Crash report or stack trace

No response

KSCrash version

2.0.0-rc.4

Operating System

iOS

OS version

iOS 18.0

Device model

No response

Xcode version

16.0

Additional context

No response

bamx23 commented 3 weeks ago

Thanks for this report. I've fixed this issue and also made a required method "sink" visible in public API (release 2.0.0-rc.5). An example of installation subclassing is now a part of the sample.