search

kstenschke / shifter-plugin

Intelligent string/code manipulation plugin for Jetbrains IDEs: Detects shiftable type of word/line/selection and manipulates it on keyboard shortcut
http://plugins.jetbrains.com/plugin/6149
Apache License 2.0
105 stars 13 forks source link

Also append or remove the unit string for common CSS preprocessor files #13

Closed eikaramba closed 9 years ago

eikaramba commented 9 years ago

Hey i fixed this little improvement myself, hope you are ok with that. I was just wondering why this new unit functionality is not working for me, but it's just because i'm working with SASS files instead of plain CSS.

kstenschke commented 9 years ago

Wow, that’s really cool, thanks a lot ! :-) If you’d let me know your real name (you can also mail me directly), i’d happily mention you in the readme. Hope you’re ok with me adapting your code a little though (i shortened it a bit, to not run filename.toLowerCase() multiple times)

greetings, Kay

Am 16.11.2014 um 21:56 schrieb eikaramba notifications@github.com:

Hey i fixed this little improvement myself, hope you are ok with that. I was just wondering why this new unit functionality is not working for me, but it's just because i'm working with SASS files instead of plain CSS.

You can merge this Pull Request by running

git pull https://github.com/eikaramba/shifter-plugin css_preprocessor_support Or view, comment on, or merge it at:

https://github.com/kstenschke/shifter-plugin/pull/13

Commit Summary

Also append or remove the unit string for common CSS preprocessor files File Changes

M src/com/kstenschke/shifter/models/ShiftableWord.java (6) Patch Links:

https://github.com/kstenschke/shifter-plugin/pull/13.patch https://github.com/kstenschke/shifter-plugin/pull/13.diff — Reply to this email directly or view it on GitHub.

eikaramba commented 9 years ago

Wow what a honor, i'm Eike Thies (btw, germany) :) Yeah i also thought about shortening it, or even use a map or something, so that latter on multiple possible filetypes could lead to different behaviours(if statements). But currently i don't have the sources integrated into my editor, so that i could not test it directly, and although the changes are fearly simple, i better make more complex adaptions when i can test them at least once ;)