kstierhoff / estimATM

A tool for planning, execution, analysis, and reporting of CPS biomass from surveys using the acoustic-trawl method (ATM)
Other
2 stars 0 forks source link

add a check for isGonadSaved for a certain barcode type #102

Closed bdschwartzkopf closed 3 months ago

bdschwartzkopf commented 9 months ago

Hoping to add code to make sure that individuals with a barcode that indicates a gonad was saved actually says in the database that a gonad was saved. Here is the text for checktrawls and the code:

This barcode type indicates that isGonadSaved should be "Y" so please confirm.

histo.check <- specimens %>% filter(startsWith(as.character(individual_ID), "0"), isGonadSaved=="N")

bdschwartzkopf commented 9 months ago

sorry for got to add another piece. This code is to check that if a barcode that starts with an A has a gonad saved (it should not). Here is the text and code

This barcode type indicates that isGonadSaved should be "N" so please confirm.

histo.check2 <- specimens %>% filter(startsWith(as.character(individual_ID), "A"), isGonadSaved=="Y")

kstierhoff commented 9 months ago

Ugh, just piling on! I kid, thanks for the feature request.

I have some coding I need to do on various fronts so I'll work this in. Having example code should help.

On Wed, Nov 29, 2023 at 11:15 AM Brittany Schwartzkopf < @.***> wrote:

sorry for got to add another piece. This code is to check that if a barcode that starts with an A has a gonad saved (it should not). Here is the text and code

This barcode type indicates that isGonadSaved should be "N" so please confirm.

histo.check2 <- specimens %>% filter(startsWith(as.character(individual_ID), "A"), isGonadSaved=="Y")

— Reply to this email directly, view it on GitHub https://github.com/kstierhoff/estimATM/issues/102#issuecomment-1832549151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARG62SYQ7TZGQ73MLUUR2LYG6CVZAVCNFSM6AAAAAA776XEMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSGU2DSMJVGE . You are receiving this because you were assigned.Message ID: @.***>

--

Kevin L. Stierhoff

Research Fisheries Biologist, NOAA/NMFS/SWFSC

kstierhoff commented 3 months ago

Implemented this functionality and tested on data in SQL Server for 2307RL. Will continue testing and improving during 2407RL.