kstonekuan / pe

0 stars 0 forks source link

Ui class diagram does not follow the standard #9

Open kstonekuan opened 3 years ago

kstonekuan commented 3 years ago

This diagram is very difficult to understand as it does not follow our standard notation. I understand it is a simplified diagram but there are not even any labels to tell me if these are methods and why they are connected in such a way.

image.png

They are even referred to as subclasses in the paragraph following but they seem to be used as methods.

image.png

nus-pe-bot commented 3 years ago

Team's Response

The UI diagram is not intended to be a class diagram per se; it is intended to be a more general object diagram to show the functions in the Ui class to the developer to use. However, the mistake of writing "a few subclasses" instead of "a few functions/methods" is valid.

We believe this severity should not be high, as the developer can continue to use the feature in the Ui (as methods) for their own functions after reading the DG. Hence, we downgraded the severity of this issue to "Medium", since developers can be occassionally inconvenienced by this mistake.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]