search

kstyrc / embedded-redis

Redis embedded server for Java integration testing
854 stars 371 forks source link

Licence - Ok to fork? #15

Closed bergetp closed 9 years ago

bergetp commented 9 years ago

Hey Kstyrc,

We are currently testing out you embedded-redis in our tests, and it seems to work great. We would probably like to fork this before starting to use it ourselves however.

I can't find a license in this repo, so is it Ok for you if we fork this? Also, there seems to be a 0.6 version on MavenCental which differs from this version. Do you have the official repo in some other place than Github perhaps?

kstyrc commented 9 years ago

Hi,

it's OK to do a fork. However, wouldn't it be better to submit pull requests here? I would like to avoid tons of forks like those: https://github.com/gbrd/embedded-redis https://github.com/nielspeter/embedded-redis

Currently mine releases are in clojars repo: https://clojars.org/redis.embedded/embedded-redis the latest is 0.3 and includes all the new features afair.

enisher commented 9 years ago

@kstyrc, seems those guys have some useful changes. Why don't you merge them in this repo?

kstyrc commented 9 years ago

@enisher The only useful change they added is that they include redis binaries for 2.8.5 & 2.8.9 Linux/Unit. I would like to avoid packaging a lot of different redis binaries in the embedded-redis jar. All in all, you can just add redis binary of your choice on classpath and invoke new RedisServer("path/to/executable", port).

kstyrc commented 9 years ago

I've added licence info to README.md. It's Apache 2.0