Closed turu closed 9 years ago
That's a really good job!
I'd like to see this PR + support for defining executable per OS in the next release. My concern:
Let me look through the code and new Redis concepts (new to me).
Hello there, See the updated title and description with additional features that have been added to this pull request. Cheers
Thanks a lot and sorry for the delay!
Following changes have been introduced (updated on 01.02.2015):
Basically, now you can write a test like:
You can create an arbitrary Redis cluster that way. The one above is a Redis HA cluster with 3 sentinels (quorum size 2) and 3 masters, each having their own replication slave.
To achieve that, a major refactor was needed as well. Tell me what you think.
EDIT on 01.02.2015: We encountered a scenario when you can have many builds using embedded-redis in tests, running simultaneously on CI server. Therefore I implemented a feature that allows one to create clusters on predefined or free ephemeral ports that are selected automatically to avoid possible clashes or race conditions.
Example usage is shown in updated README.md (see Setting up a cluster section).