search

kstyrc / embedded-redis

Redis embedded server for Java integration testing
840 stars 368 forks source link

max heap setting does not work #77

Open rdgreen opened 7 years ago

rdgreen commented 7 years ago

I don't seem to have a locally-installed redis so it should be using the Linux 64-bit one inside the jar.

*** FATAL CONFIG FILE ERROR ***
Reading the configuration file, at line 3
>>> 'maxheap 128M'
Bad directive or wrong number of arguments
rdgreen commented 7 years ago

it's not maxheap it's maxmemory. Typo in the README.

zegerhoogeboom commented 7 years ago

I also ran into this, however on windows the maxheap option DID work.

MonkeyTonk commented 6 years ago

At least you don't get a fatal error on windows. I checked the conf file on windows and it does not mention a maxheap option but # maxmemory <bytes>.
I also checked the self documented conf files (versions 2.4, 2.6, 2.8 and 3.0) at redis conf documentation and couldn't find a maxheap option.
Therefore I would recommend using the maxmemory option.

zabetak commented 3 years ago

I am a bit confused with commit https://github.com/kstyrc/embedded-redis/commit/db9a01ba34ca160876cd5ece5c9cfc3e4b4a4dc0 by @jonfreedman. The discussion above suggests to use maxmemory instead of maxheap and the commit contradicts that. Can somebody shed some light to this?

jonfreedman commented 3 years ago

@zabetak that's not my commit, I was saying the same thing as you...

zabetak commented 3 years ago

Aaahh yes just realized :D Thanks for replying @jonfreedman