Not resetting redisConfigBuilder in RedisServerBuilder.

kstyrc / embedded-redis

Redis embedded server for Java integration testing

856 stars 372 forks source link

Not resetting redisConfigBuilder in RedisServerBuilder. #96

Closed jakubstuglik closed 6 years ago

jakubstuglik commented 6 years ago

Resetting redisConfigBuilder is forgetting settings which might have been added by client by using withServerBuilder method on RedisClusterBuilder. So it shouldn't be reset during master and slaves creation.

pavankumar-dv commented 5 years ago

Shouldn't this be applicable for RedisSentinelBuilder as well ? My use case is exactly same as mentioned here. https://github.com/kstyrc/embedded-redis/issues/97

Here is the approach to achieve the AUTH capability?

Create SentinelBuilder with setting("config set requirepass abcde")
use the above sentinelBuilder to redisClusterBuilder.withSentinelBuilder() to create cluster.

However in buildSentinels(), the config that was set earlier is getting reset. @kstyrc @jakubstuglik