search

ksudeep11 / pywebsocket

Automatically exported from code.google.com/p/pywebsocket
0 stars 0 forks source link

Implement draft-ietf-hybi-thewebsocketprotocol-08 #103

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
http://tools.ietf.org/id/draft-ietf-hybi-thewebsocketprotocol-08.txt

Semantic changes
- Absolute path is now allowed for resource
- extension parameter is token
- Sec-WebSocket?-Protocol from server to client is token
- Status code 1005 and 1006
- Internal error results in 1005

Original issue reported on code.google.com by toyoshim@chromium.org on 13 Jul 2011 at 4:55

GoogleCodeExporter commented 9 years ago 
diff memo
 - Sec-WebSocket-Version: 8
 - Send appropriate HTTP error code for invalid |Sec-WebSocket-Origin| (optional)
 - URI handling by RFC 5234 and absolute URI on Request-URI
 - Ignore unknown non-zero RSV1,2,3.
 - Close frame's first two bytes mean 'unsigned' 16-bit integer
 - After closing handshake, server MUST close TCP ASAP, then client do.
 - Remove quoted-string from subprotocols parsing
 - Use the same error codes on opening handshake which are clarified in spec (5.2.2.)
 - Extension name registry
 - Subprotocol name registry

Original comment by toyoshim@chromium.org on 13 Jul 2011 at 5:49

GoogleCodeExporter commented 9 years ago 
http://code.google.com/p/pywebsocket/source/detail?r=504
 - Sec-WebSocket-Version: 8

Original comment by toyoshim@chromium.org on 13 Jul 2011 at 10:12

GoogleCodeExporter commented 9 years ago

Original comment by toyoshim@chromium.org on 13 Jul 2011 at 10:12

GoogleCodeExporter commented 9 years ago 
http://codereview.appspot.com/4785042/
 - extension parameter is token
 - Sec-WebSocket?-Protocol from server to client is token
 - Remove quoted-string from subprotocols parsing

TODO:
 - Absolute path is now allowed for resource
 - Status code 1005 and 1006
 - Internal error results in 1005 -> 1006
 - Send appropriate HTTP error code for invalid |Sec-WebSocket-Origin| (optional)
 - URI handling by RFC 5234 and absolute URI on Request-URI
 - Ignore unknown non-zero RSV1,2,3.
 - Close frame's first two bytes mean 'unsigned' 16-bit integer
 - After closing handshake, server MUST close TCP ASAP, then client do.
 - Use the same error codes on opening handshake which are clarified in spec (5.2.2.)
 - Extension name registry
 - Subprotocol name registry

Original comment by toyoshim@chromium.org on 20 Jul 2011 at 3:02

GoogleCodeExporter commented 9 years ago 
http://codereview.appspot.com/4803042/
 - Status code 1005, 1006 (and 1007 for HyBi-10)
 - Internal error results in 1006

TODO:
 - Absolute path is now allowed for resource
 - Send appropriate HTTP error code for invalid |Sec-WebSocket-Origin| (optional)
 - URI handling by RFC 5234 and absolute URI on Request-URI
 - Ignore unknown non-zero RSV1,2,3.
 - Close frame's first two bytes mean 'unsigned' 16-bit integer
 - After closing handshake, server MUST close TCP ASAP, then client do.
 - Use the same error codes on opening handshake which are clarified in spec (5.2.2.)
 - Extension name registry
 - Subprotocol name registry

Original comment by toyoshim@chromium.org on 20 Jul 2011 at 6:53

GoogleCodeExporter commented 9 years ago

Original comment by toyoshim@chromium.org on 20 Jul 2011 at 6:55

GoogleCodeExporter commented 9 years ago 
Dispose a following requirement because it will disappear in HyBi-09 and later
 - Ignore unknown non-zero RSV1,2,3.

Dispose following memos because current implementation satisfy the specification
 - Close frame's first two bytes mean 'unsigned' 16-bit integer
 - Extension name registry
 - Subprotocol name registry

TODO:
 - Absolute path is now allowed for resource / URI handling by RFC 5234 and absolute URI on Request-URI
 - Send appropriate HTTP error code for invalid |Sec-WebSocket-Origin| (optional)
 - After closing handshake, server MUST close TCP ASAP, then client do.
 - Use the same error codes on opening handshake which are clarified in spec (5.2.2.)

Original comment by toyoshim@chromium.org on 20 Jul 2011 at 7:49

GoogleCodeExporter commented 9 years ago 
http://codereview.appspot.com/4819052/
 - Absolute path is now allowed for resource / URI handling by RFC 5234 and absolute URI on Request-URI

TODO:
 - Check fallback http status codes as clarified in spec 5.2.2.
 - Check server close TCP ASAP, then client do after closing handshake.

Original comment by toyoshim@chromium.org on 8 Aug 2011 at 1:06

GoogleCodeExporter commented 9 years ago 
http://codereview.appspot.com/4801085/
  - Send appropriate HTTP error code for invalid |Sec-WebSocket-Origin| (optional)
  - Check fallback http status codes as clarified in spec 5.2.2.

This change could be the last one for HyBi-08 and 09.

Original comment by toyos...@google.com on 9 Aug 2011 at 12:49

GoogleCodeExporter commented 9 years ago

Original comment by toyoshim@chromium.org on 23 Aug 2011 at 1:52