search

ksundberg / CS5500

Course project for CS5500 at Utah State University
GNU General Public License v2.0
2 stars 11 forks source link

Undo/cleanup #59

Closed sharpTrick closed 9 years ago

sharpTrick commented 9 years ago

I realize it was my fault for not diving into all the pull requests to stop this from happening. However just so everybody knows now.

THIS CODE IS NOT TRASH

I have plans to tie it in to the chunkmanager as discussed with @waredavid and his partner.

I do not know for sure but I also think that the removal of the physics engine was probably premature as well.

(Really this pull could wait until we tied it in, however it would be nice for it to be in the master branch so that I don't have to keep backups or fancy branches off of outdated commits to re incorporate them later)

tefu commented 9 years ago

Make sure to add c++ files back into CMakeLists.txt if you want to see them compile. From a cursory glance, I don't think they will right now.

Also, WorldFactory isn't really necessary. There's already a generate function in the World class right now that sets up its initial state.

Factories are generally used to decouple constructors from classes, so without a good reason to do that, a constructor should work just fine.

ksundberg commented 9 years ago

This pull has no effect as none of the files are compiled, or referenced. Please address this and then I'll consider it for merging.