search

kswedberg / jquery-carousel-lite

A jQuery carousel plugin based on jCarouselLite by Ganeshji Marwaha
MIT License
177 stars 59 forks source link

Height of elements #19

Closed s7anley closed 12 years ago

s7anley commented 12 years ago

Hi,

I just stared using your plugin instead of original Ganeshji Marwaha script. I found same problem in your code, which exists in original script too. When elements doesn't have same height and I still want use autoCSS, script sets height of first element to all other siblings.

Is this the desired behavior?

Thanks for answer. Ján

kswedberg commented 12 years ago

Yeah, this is the desired behavior. You can turn off the autoCSS and set the height yourself, but otherwise we have to base the height on something and the first <li> seems like a reasonable choice. We do that because we also need to set overflow: hidden and want to ensure you can see the elements.

s7anley commented 12 years ago

If it's desired then fine, I wasn't sure. I will just manage my own repo then. I made little change in o.autoCSS part, where I calculate max height of <li> instead.

Only one question, which tool are you using for minification? Thanks.

kswedberg commented 12 years ago

Yeah, setting it to max height is another way to go, but looping through all elements and checking their height could get expensive. Tradeoffs.

I've been using Google Closure Compiler for this project, but at some point I'll probably move to uglifyjs.