search

kswedberg / jquery-carousel-lite

A jQuery carousel plugin based on jCarouselLite by Ganeshji Marwaha
MIT License
177 stars 59 forks source link

Up and down page scrolling over carousel area supported? #27

Closed jimmykhlam closed 10 years ago

jimmykhlam commented 11 years ago

The plugin seems to block normal vertical scrolling when trying to swipe up and down to touch scroll over the carousel area.

kswedberg commented 11 years ago

Sorry for the delay. Yeah, I'm preventing default action on touch move. It can be disorienting if the page moves around while trying to swipe horizontally. Would it be sufficient to have it prevent default only until the vertical swiping reaches the swipeThresholds.y limit?

davgilbert commented 10 years ago

Is normal vertical browser scrolling likely to be enabled over this plugin in the near future? It would be a really useful edition with the increased amount of adaptive websites being built these days. And if not, I think your suggested resolution to this issue would be an improvement.

kswedberg commented 10 years ago

@davgilbert thanks for bringing this issue to my attention again. You raise a good point. I'll see what I can do.

davgilbert commented 10 years ago

Thank you very much!

kswedberg commented 10 years ago

no problem, @davgilbert . Sorry it took so long to address the issue. I'm still not entirely happy with the solution. It seems that once the touchmove event starts firing, any attempt to conditionally start or stop preventing default don't have any effect. I was hoping to be able to prevent default until the change on the y axis went past a given threshold, at which point the browser's scrolling would kick in, but this doesn't appear to work, at least not in Mobile Safari.