search

kswedberg / jquery-carousel-lite

A jQuery carousel plugin based on jCarouselLite by Ganeshji Marwaha
MIT License
177 stars 59 forks source link

trigger('EndCarousel') seems to be ending all active carousels #30

Closed roscopeeco closed 10 years ago

roscopeeco commented 11 years ago

Hello Karl,

I'm using your plugin quite extensively having upgraded from the original and often have multiple carousels on a page.

There is a widget i've created that is trying to make use of the 'endCarousel' event but it looks like when it is called it clears any existing carousel regardless of element specified.

$(settings.placeholder).trigger('endCarousel');

i originally thought i t may be a css issue but when i removed the endcarousel statement everything worked ok on the other sliders.

Thanks

Ross

kswedberg commented 10 years ago

Hi Ross,

I can't reproduce the problem you're having. If you could show me an example of the problem, like on jsbin.com or something, that would be great.

Make sure you are triggering endCarousel only on the specific carousel you want to end. For example, if you have five carousels and you initialize them with $('div.carousel').jCarouselLite(), you would need to do $('div.carousel').last().jCarouselLite('endCarousel') to end the fifth one.

travco commented 10 years ago

I'm in the same boat as @kswedberg, I don't know exactly what the context was, but in everything I've tried I can't reproduce this. Given the amount of time that has passed I'd say it was resolved without reply.

Close issue?

kswedberg commented 10 years ago

Thanks, @travco. Yeah, I'm just gonna close this since I haven't heard back from @roscopeeco and I can't reproduce the problem.