Added ulSelector and liSelector into the options for selector customization

tatemz commented 10 years ago

Added ulSelector and liSelector for the options to customize the corresponding jQuery DOM selectors.

roscopeeco commented 10 years ago

Hi everyone

It would be great if this selector options could be added in as i have been needing something like tihs on a 'widget' i regularly use.

The carousel contains content which is loaded at start-up but i want to introduce lazy loading so that the content is added to lists item when it is requested via a menu click. With the selector option it would allow me to do this by only using the li's with a certain class (the empty li's would be hidden).

Only one li is displayed at time so when the content switches it would only display the li's with content. At the moment i can't do this as when the carousel switches blank li's are displayed in between the content while transitioning.

Hope this outlines a valid use case.

cheers Ross

kswedberg commented 10 years ago

@tatemz: I'd like to merge in this feature, but a few changes need to happen first:

Rebase from upstream master, since I've updated a bunch of stuff, including significant indentation changes, which will otherwise create conflicts when merging. (Sorry. Totally my fault.)
Make all your changes in src/jquery.jcarousellite.js. Don't bother minifying or anything like that. After I merge and test, I'll run a grunt task that copies the "src" file to the root directory and minifies it to the *.min.js file.
Change ulSelector to containerSelector and change liSelector to itemSelector. If we're going to allow for user-defined selectors, it's quite possible they'll be some element other than a ul or li.
Remove the lines that change the pageNav variable ( see @gnarf's and my comments: https://github.com/kswedberg/jquery-carousel-lite/pull/33#discussion_r10492632 )

If all of this is too much of a hassle for you, that's ok, but please let me know either way. If you'd rather I do this now, I'll give you a "shout out" in the commit message.

tatemz commented 10 years ago

Dang, it's been a while since I even touched this. I was going to use the carousel on an old project, but ended up abandoning it after too much hassle. I'll go ahead and make a commit sometime today after lunch (CT).

kswedberg commented 10 years ago

Yeah, sorry about letting this languish, @tatemz. I appreciate your help!

tatemz commented 10 years ago

Didn't get to do it at lunch. Just now getting around to working on it. Commit incoming.

tatemz commented 10 years ago

Committed and pull request updated...

tatemz commented 10 years ago

To preview additional documentation: https://github.com/tatemz/jquery-carousel-lite/tree/98fd2d3af2c78037c47477b4610b635f2d473c3f

kswedberg commented 10 years ago

Thank you, @tatemz! Merged in at 89c9bd9381a2978a965bc735a7f42801fa9c66fe

kswedberg / jquery-carousel-lite

Added ulSelector and liSelector into the options for selector customization #33