search

kswedberg / jquery-carousel-lite

A jQuery carousel plugin based on jCarouselLite by Ganeshji Marwaha
MIT License
177 stars 59 forks source link

Correction of an error in the destruction of the carousel #37

Closed klamath closed 10 years ago

klamath commented 10 years ago

Hi it seems that there is a bug when removing event listeners from 'btnGo'

In this case: $.each(o.btnGo, function(i, val) { The 'each' method will iterate over a string variable, that contains class names, but not jquery objects..

and $(val).unbind('.jc'); will produce error.

kswedberg commented 10 years ago

Can you give me an example of a valid value for the btnGo option that will produce the error? The $.each() can take a plain object or array as its first argument. Inside the callback, $(val) will use a string from an array or plain object as a selector for the jQuery function. So, I'm having a hard time thinking of a case where this would fail. In any case, I need to put a failing case in a unit test before I can fix it (or you could do that, in test/tests.js, if you'd like).

kswedberg commented 10 years ago

@klamath, since it's been over 2 months and I haven't heard back from you, I'm going to close this. If you can help clarify what's going on, I'd be happy to reopen.